Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status call returns error when node is not registered to a multiparty namespace #1453

Closed
chrisbygrave opened this issue Jan 23, 2024 · 2 comments

Comments

@chrisbygrave
Copy link

Before this change I could register my org using the org/self API, and then subsequently register my node using self/node. In the time between the two registrations completing successfully, FireFly ran normally and I could call /status to check on the completion of the registration calls.

After the above change, I am getting an error from the /status call:

{"error":"FF10225: Unable to resolve the local node. Please ensure node.name is configured"}

It looks like the change has resulted in the missing node name being treated as an error rather than an acceptable state. This makes client logic more difficult to manage - if registration requires two separate asynchronous calls, then being in a state where one has completed without the other needs to be tolerated.

@peterbroadhurst
Copy link
Contributor

Thanks @chrisbygrave - I think it's worth considering #1450 alongside this when we get an owner, as they're likely to be architecturally in the same place

@chrisbygrave
Copy link
Author

Now fixed by kaleido-io#102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants