Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ERC20/ERC721 contracts generated by OpenZeppelin #90

Closed
awrichar opened this issue Sep 16, 2022 · 3 comments
Closed

Add support for ERC20/ERC721 contracts generated by OpenZeppelin #90

awrichar opened this issue Sep 16, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@awrichar
Copy link
Contributor

awrichar commented Sep 16, 2022

OpenZeppelin provides a contract wizard for generating common token contracts:
https://docs.openzeppelin.com/contracts/4.x/wizard

The method names and signatures in these contracts (for things like mint/transfer/burn) differ slightly from the samples already checked into this repository. We should add support for these in the ABI map here:

const abiMethodMap = new Map<ContractSchemaStrings, AbiMethods>();

Note that most/all of these methods may not include extra "data" arguments, so FireFly will not be able to write extra data to the chain (such as transaction and message IDs) when using these contracts - this is accepted as a known limitation.

@awrichar
Copy link
Contributor Author

Also note concerns with the existing naming of sample schemas, as detailed in #63

@sudo-monkey
Copy link

hopefully it's not too much to ask. But would it be possible to include ERC1155 as well?

@nguyer
Copy link
Contributor

nguyer commented Jan 19, 2023

Resolved in #104

@nguyer nguyer closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants