Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action to run Makefile #43

Open
nguyer opened this issue Jun 15, 2021 · 3 comments
Open

Add GitHub Action to run Makefile #43

nguyer opened this issue Jun 15, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nguyer
Copy link
Contributor

nguyer commented Jun 15, 2021

In order to make sure PRs are acceptable, we should be testing that the code compiles and passes all the linting rules added in #42
@nguyer nguyer added enhancement New feature or request good first issue Good for newcomers labels Jun 15, 2021
@shorsher
Copy link
Member

shorsher commented Aug 5, 2021

With the addition of goreleaser in #76, do we still need this?

@nguyer
Copy link
Contributor Author

nguyer commented Aug 10, 2021

I think we still need this. I'd like to have assurance that changes in a PR won't prevent make from running locally before things get merged.

@yuriechan
Copy link

Hi, should this issue be closed?
It seems like the change has been merged.
#98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nguyer @shorsher @yuriechan