Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote RPC Erc1155 Token Connector CLI check #237

Open
monar24 opened this issue Jan 26, 2023 · 1 comment
Open

Remote RPC Erc1155 Token Connector CLI check #237

monar24 opened this issue Jan 26, 2023 · 1 comment

Comments

@monar24
Copy link

monar24 commented Jan 26, 2023

Currently initializing a remote blockchain stack with an erc-1155 token connector as follows:

ff init polygon 1 \
    --multiparty=false \
    -b ethereum \
    -c evmconnect \
    -n remote-rpc \
    -t erc1155 \
    --remote-node-url https://staging.arkane.network/\
    --chain-id 80001 \
    --connector-config ~/Desktop/evmconnect.yml

Throws the following due to a check in the CLI:

return errors.New("erc1155 is currently not supported with a remote-rpc node")

This check was created to prevent automatic deployment of factory contracts for erc1155.

Steps for solution:
1- Build CLI with check disabled
2- Address any issues that arise from the CLI or connector

@awrichar
Copy link
Contributor

From a very quick look, I think removing this check from the CLI may actually behave alright (from a CLI perspective). The main thing there is to be sure it doesn't try to auto-deploy any contracts... seems like it won't, but worth a double-check.

I think the bigger issue may be that the https://github.com/hyperledger/firefly-tokens-erc1155 container will have issues if it's started without a CONTRACT_ADDRESS or ETHCONNECT_INSTANCE. There's no reason it can't function without a built-in factory now (because you can point it at the address of one with each pool you create) - but I think it was coded to not come up unless it has a pre-deployed contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants