Remove duplicate pull of token/blockchain docker images #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the addition of Stack.VersionManifest, that manifest is now the de facto source of all images for the stack. There is no need to iterate over the plugins' Docker service definitions a second time (which are now also generated from the same VersionManifest). Fixes hyperledger#119 Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
|
There are images provided by the blockchain provider that are not in the manifest file though. For example, geth, besu, ethsigner, fabric-peer, fabric-orderer, fabric-ca. The problem is that I agree that some work needs to be done here. It sounds like we just need to deduplicate the images in the list that get pulled. But I just wanted to provide a bit background info on why explicitly pulling with retry was important. |
|
Fixed by #177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of Stack.VersionManifest, that manifest is now the de facto
source of all images for the stack. There is no need to iterate over the
plugins' Docker service definitions a second time (which are now also generated
from the same VersionManifest).
Fixes #119