Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BFT Block Puller: unit test the DeliveryRequester #4567

Open
Tracked by #4240
tock-ibm opened this issue Dec 6, 2023 · 5 comments · Fixed by #4798 · May be fixed by #4826
Open
Tracked by #4240

BFT Block Puller: unit test the DeliveryRequester #4567

tock-ibm opened this issue Dec 6, 2023 · 5 comments · Fixed by #4798 · May be fixed by #4826

Comments

@tock-ibm
Copy link
Contributor

tock-ibm commented Dec 6, 2023 •
edited

add unit tests for the
internal/pkg/peer/blocksprovider/delivery_requester.go
against a real GRPC service, with security etc.
@tock-ibm tock-ibm mentioned this issue Dec 6, 2023
Open
31 tasks
@solo-daemon
Copy link
Contributor

@tock-ibm I would like to work on this. Is someone working on this?

@solo-daemon
Copy link
Contributor

Also it seems that the file may have been moved to common/deliverclient/blocksprovider/delivery_requester.go

@solo-daemon solo-daemon mentioned this issue Apr 7, 2024
Merged
@tock-ibm tock-ibm reopened this Apr 17, 2024
@tock-ibm
Copy link
Contributor Author

tock-ibm commented Apr 17, 2024 •
edited

@solo-daemon Thanks for the contribution! I merged your unit tests PR, but see comments here:
#4798 (comment)

If you could address these comments in a new PR that would be great.

@solo-daemon
Copy link
Contributor

@tock-ibm sure I would add another pr shortly.

@solo-daemon solo-daemon linked a pull request Apr 24, 2024 that will close this issue
Draft
@solo-daemon
Copy link
Contributor

@tock-ibm I have added the suggested changes please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tock-ibm @solo-daemon