Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI, Golint Check before building PR #729

Open
chenchanglew opened this issue Oct 10, 2023 · 2 comments
Open

CI, Golint Check before building PR #729

chenchanglew opened this issue Oct 10, 2023 · 2 comments
Labels
feature help wanted Extra attention is needed

Comments

@chenchanglew
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I had a Golang lint error after 20 minutes of docker build. Maybe we can add a new Golint checking before building docker image in CI.

Describe the solution you'd like
Current CI Flow:

Set up job
Run actions/checkout@v4
Run dorny/paths-filter@v2
build dev image
fetch dev image
run make inside dev container
....

Suggest CI Flow:

Set up job
Run actions/checkout@v4
Run dorny/paths-filter@v2
golint checking
build dev image
fetch dev image
run make inside dev container
....

Describe alternatives you've considered
Or any step before run make inside dev container

@mbrandenburger
Copy link
Contributor

Need to check if we can run the check target before build.

The current order is defined here:
https://github.com/hyperledger/fabric-private-chaincode/blob/main/build.mk#L20

@mbrandenburger
Copy link
Contributor

Another issue is that we need to generate proto files otherwise the linter is not happy with go and cpp code :/

@mbrandenburger mbrandenburger added the help wanted Extra attention is needed label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants