Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(github): shorten ci.yaml workflow and job names #2624

Open
petermetz opened this issue Aug 18, 2023 · 4 comments · May be fixed by #3212
Open

chore(github): shorten ci.yaml workflow and job names #2624

petermetz opened this issue Aug 18, 2023 · 4 comments · May be fixed by #3212
Assignees
@zondervancalvez
Labels
Developer_Experience P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@petermetz
Copy link
Member

Description

As a maintainer I want to see which jobs are executing so that I'm having a better developer experience while contributing to the project which will make me happier and more productive in general while working on the project.

The screenshot below demonstrates the problem very well. The job names are getting cropped by GitHub's UI and are indistinguishable from each other.

image

Acceptance Criteria

  1. Each job has it's name shortened but still unique so that we can definitively identify the jobs despite the shorter names.

cc: @jagpreetsinghsasan Because he has a big PR pending with a big refactor where the job names are also relevant (the dynamic diff analysis PR)
@petermetz petermetz added Developer_Experience Tests Anything related to tests be that automatic or manual, integration or unit, etc. P3 Priority 3: Medium labels Aug 18, 2023
@petermetz petermetz self-assigned this Aug 18, 2023
@jagpreetsinghsasan
Copy link
Contributor

True that. We can remove cactus-plugin-*- from each of the names and still have some way of automatically picking up names from the reduced naming schema.

@Dev-Destructor
Copy link

Hii, since I am working on #2639
I will also shorten their names.

@petermetz
Copy link
Member Author

Hii, since I am working on #2639 I will also shorten their names.

@Dev-Destructor That's fine but please make sure to include the new env variable with the fully qualified package name in each of the jobs so that tooling scripts can parse it regardless of the job's name. As an example to this, see the fabric connector jobs that I broke up into N smaller jobs with shorter names and included the full npm package name in the env vars.
Please also make sure that the env var's name is the same that I used so that it's consistent across the project!

@zondervancalvez
Copy link
Contributor

Please assign this to me @jagpreetsinghsasan

zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Apr 17, 2024
@zondervancalvez
chore(github): shorten ci.yaml workflow and job names
cb20bdd 
ce - cactus-example
cp - cactus-plugin
cpk - cactus-plugin-keychain
cpl - cactus-plugin-ledger
cpp - cactus-plugin-persistence
ct - cactus-test
ctp - cactus-test-plugin

Fixes: hyperledger#2624

Signed-off-by: zondervancalvez <zondervan.v.calvez@accenture.com>
@zondervancalvez zondervancalvez linked a pull request Apr 17, 2024 that will close this issue
Open
5 tasks
zondervancalvez pushed a commit to zondervancalvez/cactus that referenced this issue Apr 17, 2024
@petermetz @zondervancalvez
chore(github): shorten ci.yaml workflow and job names
62e1653 
ce - cactus-example
cp - cactus-plugin
cpk - cactus-plugin-keychain
cpl - cactus-plugin-ledger
cplc - cactus-plugin-ledger-connector
cpp - cactus-plugin-persistence
ct - cactus-test
ctp - cactus-test-plugin

Fixes: hyperledger#2624

Signed-off-by: zondervancalvez <zondervan.v.calvez@accenture.com>
zondervancalvez pushed a commit to zondervancalvez/cactus that referenced this issue Apr 17, 2024
@petermetz @zondervancalvez
chore(github): shorten ci.yaml workflow and job names
411a3e4 
ce - cactus-example
cp - cactus-plugin
cpk - cactus-plugin-keychain
cpl - cactus-plugin-ledger
cplc - cactus-plugin-ledger-connector
plc - plugin-ledger-connector
cpp - cactus-plugin-persistence
ct - cactus-test
ctp - cactus-test-plugin

Fixes: hyperledger#2624

Signed-off-by: zondervancalvez <zondervan.v.calvez@accenture.com>
zondervancalvez pushed a commit to zondervancalvez/cactus that referenced this issue Apr 17, 2024
@petermetz @zondervancalvez
chore(github): shorten ci.yaml workflow and job names
4028b44 
ce - cactus-example
cp - cactus-plugin
cpk - cactus-plugin-keychain
cpl - cactus-plugin-ledger
cplc - cactus-plugin-ledger-connector
plc - plugin-ledger-connector
cpp - cactus-plugin-persistence
ct - cactus-test
ctp - cactus-test-plugin

Fixes: hyperledger#2624

Signed-off-by: zondervancalvez <zondervan.v.calvez@accenture.com>
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Apr 17, 2024
@zondervancalvez
chore(github): shorten ci.yaml workflow and job names
a06cf5e 
ce - cactus-example
cp - cactus-plugin
cpk - cactus-plugin-keychain
cpl - cactus-plugin-ledger
cplc - cactus-plugin-ledger-connector
plc - plugin-ledger-connector
cpp - cactus-plugin-persistence
ct - cactus-test
ctp - cactus-test-plugin

Fixes: hyperledger#2624

Signed-off-by: zondervancalvez <zondervan.v.calvez@accenture.com>
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue May 9, 2024
@zondervancalvez
chore(github): shorten ci.yaml workflow and job names
d2b993d 
ce - cactus-example
cp - cactus-plugin
cpk - cactus-plugin-keychain
cpl - cactus-plugin-ledger
cplc - cactus-plugin-ledger-connector
plc - plugin-ledger-connector
cpp - cactus-plugin-persistence
ct - cactus-test
ctp - cactus-test-plugin

Fixes: hyperledger#2624

Signed-off-by: zondervancalvez <zondervan.v.calvez@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zondervancalvez zondervancalvez

Labels
Developer_Experience P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
Cacti_Scrum_Project_v2_Release
Status: In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(github): shorten ci.yaml workflow and job names zondervancalvez/cactus
4 participants
@petermetz @jagpreetsinghsasan @zondervancalvez @Dev-Destructor