Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): add check to validate exported types being correct #3140

Open
petermetz opened this issue Mar 23, 2024 · 0 comments
Open

ci(github): add check to validate exported types being correct #3140

petermetz opened this issue Mar 23, 2024 · 0 comments
Labels
backlog Tasks that are needed but we cannot prioritize them at present. Developer_Experience P4 Priority 4: Low Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.

Comments

@petermetz
Copy link
Member

Description

As a maintainer/reviewer I want to have automation that checks if our exports are correct for both CJS/ESM so that we are less likely to accidentally merge something that would make the exports mess up and cause import issues for the downstream libraries/applications.

https://www.npmjs.com/package/@arethetypeswrong/cli

Acceptance Criteria

  1. Does not duplicate the entire build process needlessly.
  2. Evaluate if we should do it for every commit or just prior to release issuance.
  3. Be mindful of CI resources consumed by this in general.
@petermetz petermetz added Developer_Experience Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc. P4 Priority 4: Low backlog Tasks that are needed but we cannot prioritize them at present. labels Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Tasks that are needed but we cannot prioritize them at present. Developer_Experience P4 Priority 4: Low Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petermetz