Cannot set custom value for CA istio-ingressgateway

[tbondarchuk]

What happened?

1. deployed Istio using helm chart (btw, istio operator is discouraged to use now)
2. gateway selector is different for chart:

If you installed Istio using Helm following the standard documentation, this would be "istio=ingress"

3. added --istio-ingressgateway=istio to kubectl hlf ca create command but created Gateway still has ingressgateway selector
4. after some digging found out that CA crd does not pass ingressgateway name to created resources like orderer:
   

   bevel-operator-fabric/controllers/ordnode/types.go

   Line 136 in 1a0a024

   IngressGateway string `json:"ingressGateway"`

   
   

   bevel-operator-fabric/controllers/peer/peer_controller.go

   Line 1039 in 1a0a024

   gateway := spec.Istio.IngressGateway

   
   

   bevel-operator-fabric/controllers/ca/types.go

   Line 40 in 1a0a024

   Hosts []string `json:"hosts"`

   
   

   bevel-operator-fabric/controllers/ca/ca_controller.go

   Line 534 in 1a0a024

   Istio: Istio{

What did you expect to happen?

controller to create istio Gateway with selector set to value provided in --istio-ingressgateway cli arg.

How can we reproduce it (as minimally and precisely as possible)?

kubectl hlf ca create  --image=$CA_IMAGE --version=$CA_VERSION --storage-class=standard --capacity=1Gi --name=org1-ca \
    --enroll-id=enroll --enroll-pw=enrollpw --hosts=org1-ca.localho.st --istio-port=443 --istio-ingressgateway=istio

kubectl get -oyaml gateway org1-ca-gateway | grep -2 selector

Anything else we need to know?

No response

Kubernetes version

unrelated

[tbondarchuk]

temp workaround is to use old label with new gateway chart values.yaml:

labels:
  istio: ingressgateway