Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test - Onchain permissioning #6992

Open
macfarla opened this issue Apr 24, 2024 · 0 comments
Open

Flaky test - Onchain permissioning #6992

macfarla opened this issue Apr 24, 2024 · 0 comments
Labels
flake 60% of the time it works 100% of the time. permissioning account or node permissioning testing

Comments

@macfarla
Copy link
Contributor

eg https://github.com/hyperledger/besu/actions/runs/8808880622/job/24178751716?pr=6729

NodeLocalAndOnchainPermissioningAcceptanceTest > testNodesCanConnectWhenAllowedBothOnchainAndLocally() FAILED
    org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.hyperledger.besu.tests.acceptance.dsl.condition.perm.WaitForTrueResponse 
    Expecting value to be true but was false within 30 seconds.
        at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
        at app//org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
        at app//org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
        at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
        at app//org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:769)
        at app//org.hyperledger.besu.tests.acceptance.dsl.WaitUtils.waitFor(WaitUtils.java:31)
        at app//org.hyperledger.besu.tests.acceptance.dsl.WaitUtils.waitFor(WaitUtils.java:24)
        at app//org.hyperledger.besu.tests.acceptance.dsl.condition.perm.WaitForTrueResponse.verify(WaitForTrueResponse.java:34)
        at app//org.hyperledger.besu.tests.acceptance.dsl.node.BesuNode.verify(BesuNode.java:819)
        at app//org.hyperledger.besu.tests.acceptance.permissioning.NodeLocalAndOnchainPermissioningAcceptanceTest.testNodesCanConnectWhenAllowedBothOnchainAndLocally(NodeLocalAndOnchainPermissioningAcceptanceTest.java:98)

        Caused by:
        org.opentest4j.AssertionFailedError: 
        Expecting value to be true but was false
            at jdk.internal.reflect.GeneratedConstructorAccessor29.newInstance(Unknown Source)
            at java.base@17.0.10/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
            at java.base@17.0.10/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
            at app//org.hyperledger.besu.tests.acceptance.dsl.condition.perm.WaitForTrueResponse.lambda$verify$0(WaitForTrueResponse.java:34)
            at app//org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
            at app//org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248)
            at app//org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235)
            at java.base@17.0.10/java.util.concurrent.FutureTask.run(FutureTask.java:264)
            at java.base@17.0.10/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
            at java.base@17.0.10/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
            at java.base@17.0.10/java.lang.Thread.run(Thread.java:840)

NodeSmartContractPermissioningOutOfSyncAcceptanceTest > addNodeToClusterAndVerifyNonBootNodePeerConnectionWorksAfterSync() FAILED
    org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBase 
    Expecting actual:
      14
    to be greater than or equal to:
      25
     within 2 minutes.
        at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
        at app//org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
        at app//org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
        at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
        at app//org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:769)
        at app//org.hyperledger.besu.tests.acceptance.dsl.WaitUtils.waitFor(WaitUtils.java:31)
        at app//org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBase.waitForBlockHeight(AcceptanceTestBase.java:180)
        at app//org.hyperledger.besu.tests.acceptance.permissioning.NodeSmartContractPermissioningOutOfSyncAcceptanceTest.addNodeToClusterAndVerifyNonBootNodePeerConnectionWorksAfterSync(NodeSmartContractPermissioningOutOfSyncAcceptanceTest.java:47)

        Caused by:
        java.lang.AssertionError: 
        Expecting actual:
          14
        to be greater than or equal to:
          25
            at org.hyperledger.besu.tests.acceptance.dsl.AcceptanceTestBase.lambda$waitForBlockHeight$1(AcceptanceTestBase.java:184)
            at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
            at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248)
            at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235)
            at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
            at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
            at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
            at java.base/java.lang.Thread.run(Thread.java:840)

9 tests completed, 2 failed
@macfarla macfarla added flake 60% of the time it works 100% of the time. permissioning account or node permissioning testing labels Apr 24, 2024
@macfarla macfarla changed the title Flaky test - Onchain permissioningq Flaky test - Onchain permissioning Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flake 60% of the time it works 100% of the time. permissioning account or node permissioning testing
Projects
None yet
Development

No branches or pull requests

1 participant