Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AT Cluster Restart Behaviour #6954

Open
4 tasks
siladu opened this issue Apr 16, 2024 · 0 comments
Open
4 tasks

Fix AT Cluster Restart Behaviour #6954

siladu opened this issue Apr 16, 2024 · 0 comments
Labels
dev experience The build system, things that enable easier development etc.

Comments

@siladu
Copy link
Contributor

siladu commented Apr 16, 2024

7e46889 was found to slow down the ATs by 3-4x.

It was reverted in #6948

We should revisit this considering @fab-10 comments from #6948 ...

The commit that I did, is actually fixing the intent of the test, that was to stop the cluster after each single unit tests, and start with a new one every time, that intended behavior was broken, and had the side effect of keeping previously started Besu processes around for the duration of the test class, and so had the nice side effect that for all the test methods after the first a cluster was already up to respond to requests.
So instead of reverting to the wrong but faster state, I will prefer that we understand if the initial intends of restarting the cluster after each test methods was really needed and instead replace it with a restart each test class.
It is also worth to note that ATs in CI could be re-organized to balance the time.

after a quick analysis, I found there are some steps needed to first port all the tests to Junit5, then identify test classes that do not need to have a cluster restart for every method and probably also a refactor of the base classes, so for the moment we can revert to the previous buggy but faster code, while implementing these pre tasks.

Tasks

  • Port all the tests to JUnit5
  • Identify test classes that do not need a cluster restart for every method
  • Refactor base classes
  • Replay any other fixes from 7e46889
@siladu siladu added the dev experience The build system, things that enable easier development etc. label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev experience The build system, things that enable easier development etc.
Projects
None yet
Development

No branches or pull requests

1 participant