Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonsai Look-back error during RPC should provide better UX #6926

Open
non-fungible-nelson opened this issue Apr 10, 2024 · 0 comments
Open
Labels

Comments

@non-fungible-nelson
Copy link
Contributor

Description

As a user of Besu RPC, if my node is using Bonsai storage format, the RPC should provide a unique exception if the node is attempting a look back farther than the historical-block-limit. Currently, Besu will return default or null values and not raise an exception. This is not out of spec, since the specification does not account for Bonsai-type pruning. An exception is better than null or default values in this case, as that information may be wrong entirely and considered a "successful" call-back.

This code section will need to be updated if we want to add additional exceptions based on Bonsai's limits.

Acceptance Criteria

  • Besu's RPC API is able to raise an exception when met with a block or state value older than the historical-block-limit
  • Besu should error out the API call and not return success, or a null/default value that may improperly be returned for that value (i.e. querying block 513 should not return null for certain API calls as if the value was null, but an exception for the block limit, even if the value really would be null)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant