Fix compilation warnings

[astrofrog]

There are a number of warnings being emitted by gfortran 7 when compiling with --enable-debug that would make sense to address:

fortranlib/src/lib_io.f90:759:0:

   subroutine solve_wildcard(filename)
 
Warning: 'solve_wildcard' defined but not used [-Wunused-function]
fortranlib/src/lib_array.f90:2449:29:

                 array(i,j) = array(i,j) + array_orig(ii,jj) * exp(-d/2._dp)
                             1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
fortranlib/src/lib_array.f90:2450:35:

                 array_count(i,j) = array_count(i,j) + exp(-d/2._dp)
                                   1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
fortranlib/src/lib_array.f90:2296:0:

   subroutine invert_matrix(n,a,c)
 
Warning: 'invert_matrix' defined but not used [-Wunused-function]
fortranlib/src/lib_array.f90:2347:0:

   subroutine print_matrix(a)
 
Warning: 'print_matrix' defined but not used [-Wunused-function]
fortranlib/src/lib_array.f90:2370:0:

   subroutine bin_array(n,x,y,n_bin,xmin,xmax,x_bin,y_bin)
 
Warning: 'bin_array' defined but not used [-Wunused-function]
fortranlib/src/lib_array.f90:2407:0:

   subroutine smooth_2d(array,sigma)
 
Warning: 'smooth_2d' defined but not used [-Wunused-function]
fortranlib/src/lib_random.f90:158:36:

        am=nearest(1.0_sp,-1.0_sp)/im
                                    1
Warning: Change of value in conversion from 'INTEGER(4)' to 'REAL(4)' at (1) [-Wconversion]
fortranlib/src/lib_random.f90:467:15:

              y=tan(pi*harvest)
               1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
fortranlib/src/lib_random.f90:129:0:

   subroutine random_string(string)
 
Warning: 'random_string' defined but not used [-Wunused-function]
fortranlib/src/lib_hdf5_110.f90:323:2:

   integer(size_t) function sizeof(type_id)
  1
Warning: 'sizeof' declared at (1) may shadow the intrinsic of the same name.  In order to call the intrinsic, explicit INTRINSIC declarations may be required. [-Wintrinsic-shadow]
fortranlib/src/lib_hdf5_110.f90:3563:16:

     do col_id=1,info%n_cols
                1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
fortranlib/src/lib_hdf5_110.f90:3551:19:

     do field_idx=1,info%n_cols
                   1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
fortranlib/src/lib_hdf5_110.f90:700:30:

           call h5tget_super_f(datatype_id, datatype_id, hdferr)
                              1
Warning: Same actual argument associated with INTENT(IN) argument 'type_id' and INTENT(OUT) argument 'base_type_id' at (1)
fortranlib/src/lib_hdf5_110.f90:685:19:

     do field_idx=1,info%n_cols
                   1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
fortranlib/src/lib_hdf5_110.f90:3468:35:

     logical :: is_string, is_vector
                                   1
Warning: Unused variable 'is_vector' declared at (1) [-Wunused-variable]
fortranlib/src/lib_hdf5_110.f90:3384:34:

     integer :: hdferr, rank, ndims
                                  1
Warning: Unused variable 'ndims' declared at (1) [-Wunused-variable]
fortranlib/src/lib_hdf5_110.f90:3254:34:

     integer :: hdferr, rank, ndims
                                  1
Warning: Unused variable 'ndims' declared at (1) [-Wunused-variable]
fortranlib/src/lib_hdf5_110.f90:3124:34:

     integer :: hdferr, rank, ndims
                                  1
Warning: Unused variable 'ndims' declared at (1) [-Wunused-variable]
fortranlib/src/lib_hdf5_110.f90:2994:34:

     integer :: hdferr, rank, ndims
                                  1
Warning: Unused variable 'ndims' declared at (1) [-Wunused-variable]
fortranlib/src/lib_hdf5_110.f90:587:0:

   subroutine hdf5_list_links(handle, path, links)
 
Warning: 'hdf5_list_links' defined but not used [-Wunused-function]
fortranlib/src/lib_hdf5_110.f90:1134:0:

   subroutine write_table_column_2d_h5t_native_character(handle,path,col_name,values)
 
Warning: 'write_table_column_2d_h5t_native_character' defined but not used [-Wunused-function]
fortranlib/src/type_angle3d.f90:466:13:

     a%cost = cos(theta*deg2rad)
             1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
fortranlib/src/type_angle3d.f90:467:13:

     a%sint = sin(theta*deg2rad)
             1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
fortranlib/src/type_angle3d.f90:468:13:

     a%cosp = cos(phi*deg2rad)
             1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
fortranlib/src/type_angle3d.f90:469:13:

     a%sinp = sin(phi*deg2rad)
             1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
fortranlib/src/type_angle3d.f90:714:22:

           sin_big_c = sqrt(diff)
                      1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
fortranlib/src/type_vector3d.f90:452:10:

     v%x = a%x * b
          1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
fortranlib/src/type_vector3d.f90:453:10:

     v%y = a%y * b
          1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
fortranlib/src/type_vector3d.f90:454:10:

     v%z = a%z * b
          1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
fortranlib/src/type_pdf.f90:609:34:

              sample_pdf_cont_sp = (xi * (p%r(i) - 1._dp) + 1._dp) ** (1._dp / (p%b(i) + 1._dp)) * p%x(i)
                                  1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
fortranlib/src/type_pdf.f90:540:22:

              p%r(i) = (p%x(i+1) / p%x(i)) ** (p%b(i) + 1._dp)
                      1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
src/images/image_type.f90:166:25:

     integer :: ig, n_filt
                         1
Warning: Unused variable 'n_filt' declared at (1) [-Wunused-variable]
src/dust/dust_type_4elem.f90:322:32:

   subroutine dust_emit_peeloff(d,nu,a,s,a_req)
                                1
Warning: Unused dummy argument 'd' at (1) [-Wunused-dummy-argument]
src/dust/dust_type_4elem.f90:322:35:

   subroutine dust_emit_peeloff(d,nu,a,s,a_req)
                                   1
Warning: Unused dummy argument 'nu' at (1) [-Wunused-dummy-argument]
src/dust/dust_type_4elem.f90:322:39:

   subroutine dust_emit_peeloff(d,nu,a,s,a_req)
                                       1
Warning: Unused dummy argument 's' at (1) [-Wunused-dummy-argument]
src/dust/dust_type_4elem.f90:77:36:

   subroutine dust_setup(group,d,beta)
                                    1
Warning: Unused dummy argument 'beta' at (1) [-Wunused-dummy-argument]
src/dust/dust_type_4elem.f90:90:27:

     integer :: dust_version
                           1
Warning: Unused variable 'dust_version' declared at (1) [-Wunused-variable]
src/grid/grid_geometry_cartesian_3d.f90:422:31:

   subroutine find_wall(p,radial,tnearest,id_min)
                               1
Warning: Unused dummy argument 'radial' at (1) [-Wunused-dummy-argument]
src/grid/grid_geometry_cartesian_3d.f90:301:74:

   type(grid_cell) function next_cell_wall_id(cell, direction, intersection)
                                                                          1
Warning: Unused dummy argument 'intersection' at (1) [-Wunused-dummy-argument]
src/grid/grid_geometry_cartesian_3d.f90:275:70:

   type(grid_cell) function next_cell_int(cell, direction, intersection)
                                                                      1
Warning: Unused dummy argument 'intersection' at (1) [-Wunused-dummy-argument]
src/grid/grid_pda_cartesian_3d.f90:15:49:

   real(dp) function geometrical_factor(wall, cell)
                                                 1
Warning: Unused dummy argument 'cell' at (1) [-Wunused-dummy-argument]
src/grid/grid_pda_cartesian_3d.f90:15:43:

   real(dp) function geometrical_factor(wall, cell)
                                           1
Warning: Unused dummy argument 'wall' at (1) [-Wunused-dummy-argument]
src/grid/grid_physics_3d.f90:56:18:

   logical :: debug = .false.
                  1
Warning: Unused PRIVATE module variable 'debug' declared at (1) [-Wunused-value]
src/sources/source_type.f90:903:45:

   subroutine emit_from_extern_box_peeloff(src,p,a_req)
                                             1
Warning: Unused dummy argument 'src' at (1) [-Wunused-dummy-argument]
src/sources/source_type.f90:805:45:

   subroutine emit_from_extern_sph_peeloff(src,p,a_req)
                                             1
Warning: Unused dummy argument 'src' at (1) [-Wunused-dummy-argument]
src/grid/grid_mrw_3d.f90:21:18:

   logical :: debug = .false.
                  1
Warning: Unused PRIVATE module variable 'debug' declared at (1) [-Wunused-value]
src/mpi/mpi_routines_nompi.f90:108:32:

   subroutine mp_sync_real8(value)
                                1
Warning: Unused dummy argument 'value' at (1) [-Wunused-dummy-argument]
src/mpi/mpi_routines_nompi.f90:103:32:

   subroutine mp_sync_real4(value)
                                1
Warning: Unused dummy argument 'value' at (1) [-Wunused-dummy-argument]
src/mpi/mpi_routines_nompi.f90:98:35:

   subroutine mp_sync_integer8(value)
                                   1
Warning: Unused dummy argument 'value' at (1) [-Wunused-dummy-argument]
src/mpi/mpi_routines_nompi.f90:93:35:

   subroutine mp_sync_integer4(value)
                                   1
Warning: Unused dummy argument 'value' at (1) [-Wunused-dummy-argument]
src/mpi/mpi_routines_nompi.f90:88:47:

   subroutine mp_broadcast_convergence(converged)
                                               1
Warning: Unused dummy argument 'converged' at (1) [-Wunused-dummy-argument]
src/main/iter_lucy.f90:139:31:

                 do mrw_steps=1,n_mrw_max
                               1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
src/main/iter_lucy.f90:161:24:

                 do ia=1,n_reabs_max
                        1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
src/main/iter_lucy.f90:133:28:

           do interactions=1, n_inter_max+1
                            1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
src/main/iter_lucy.f90:127:15:

        do ip=1,n_photons
               1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
src/main/iter_final.f90:168:25:

           do mrw_steps=1,n_mrw_max
                         1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
src/main/iter_final.f90:217:18:

           do ia=1,n_reabs_max
                  1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
src/main/iter_final.f90:113:15:

        do ip=1,n_photons
               1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
src/main/iter_final.f90:156:18:

     real(dp) :: xi, weight
                  1
Warning: Unused variable 'xi' declared at (1) [-Wunused-variable]
src/main/iter_final_mono.f90:282:18:

           do ia=1,n_reabs_max
                  1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
src/main/iter_final_mono.f90:110:21:

              do ip=1,n_photons
                     1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
src/main/iter_final_mono.f90:181:24:

                 do ip=1,n_photons
                        1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
src/main/iter_final_mono.f90:240:18:

     real(dp) :: xi, weight
                  1
Warning: Unused variable 'xi' declared at (1) [-Wunused-variable]
src/main/iter_raytracing.f90:69:18:

           do ip=1,n_photons
                  1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]
src/main/iter_raytracing.f90:113:18:

           do ip=1,n_photons
                  1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4) at (1) [-Wconversion]

Some will need to be fixed in fortranlib first.