Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the UI not look ugly #8

Open
bcomnes opened this issue Jul 26, 2019 · 6 comments
Open

Make the UI not look ugly #8

bcomnes opened this issue Jul 26, 2019 · 6 comments

Comments

@bcomnes
Copy link
Contributor

bcomnes commented Jul 26, 2019

There are two UIs to deal with in VHS-tape:

  1. The test level UI and layout (e.g. the elements that you get off t.element and surrounding information)
  2. The eventual, soon to come, storybook-like UI wrapper thing. (Tracked in Interactive test runner.  #27)

This issue pertains to 1.

Here is what I was thinking, and it may require bigger changes.

  • Test elements have a min width/hight, so small components stack up nice and uniformly.
  • They need to support growing as well, for components that represent full screen or larger elements.
  • Add some minimal, but basic styling (e.g. system fonts, and some baseline colors/borders for the containers so it doesn't look like default HTML) to the test elements in a very scoped way, so that it doesn't affect its children (the tests) (e.g. using > and other specific selectors) or inherit the component global styles.

Test metadata and stuff have a lot of constraints around it, since I eventually want to load in individual VHS test files into iframes in the wrapper, and support only testing in a tape-y way (e.g. when you want to run a single test in a file and none of the others).

@tony-go
Copy link
Contributor

tony-go commented Aug 8, 2019

In the console ?

@bcomnes
Copy link
Contributor Author

bcomnes commented Aug 8, 2019

No, when you run interactively in the browser.

@tony-go
Copy link
Contributor

tony-go commented Sep 1, 2019

Here an idea of the revisited interactive UI

vhs

It's not very sophisticated, but I prefer to show you this before go further.

Did you have an idea of how can I get the status of the test or test suit (failed or success) ? I found a global event 'onFinish', but it trigs the end of execution. (Maybe I skipped something)

@bcomnes
Copy link
Contributor Author

bcomnes commented Sep 2, 2019

Cool @tony-go! It looks like the right direction. Let me clarify the OP some more.

@bcomnes
Copy link
Contributor Author

bcomnes commented Sep 2, 2019

Generally, with the addition of what I just added to the OP, lets drop the metadata header for now, and just aim to get the styling in place to close this issue:

Screen Shot 2019-09-02 at 10 03 07 AM

@tony-go
Copy link
Contributor

tony-go commented Sep 15, 2019

Hi,

Sorry for the wait :)

From what I can read, I think that "The eventual, soon to come, storybook-like UI wrapper thing" will fix this 3 points.

What do you think about start somethin' with https://github.com/yoshuawuyts/previewify ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants