Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit funding agencies to USA and explore performance enhancements #5404

Closed
devincowan opened this issue Mar 6, 2024 · 1 comment · Fixed by #5481
Closed

Limit funding agencies to USA and explore performance enhancements #5404

devincowan opened this issue Mar 6, 2024 · 1 comment · Fixed by #5481
Assignees
@devincowan
Labels
bug Broad category when more specific Label can't be found enhancement Pages and General HS Components Resource Landing Page resource landing page issues
Projects
HydroShare Issue Management Board

Comments

@devincowan
Copy link
Contributor

When attempting to add/update a funding agency, the typeahead does not prioritize results well.
For example, typing "National Science" will not return NSF. Instead it returns a bunch of international funders.
image

image

Also, the typeahead returns more lethargically than in its original implementation. See if there are changes in the Crossreff API
HS v 2.13.3
@devincowan devincowan self-assigned this Mar 6, 2024
@devincowan devincowan added this to Backlog in HydroShare Issue Management Board via automation Mar 6, 2024
@devincowan devincowan moved this from Backlog to In Progress in HydroShare Issue Management Board Mar 6, 2024
@devincowan devincowan moved this from In Progress to Selected Next for Development in HydroShare Issue Management Board Mar 6, 2024
@devincowan devincowan moved this from Selected Next for Development to In Progress in HydroShare Issue Management Board Apr 24, 2024
@devincowan devincowan added the bug Broad category when more specific Label can't be found label Apr 24, 2024
devincowan added a commit that referenced this issue May 13, 2024
@devincowan
[#5404] Update funding agency app to limit queries to United States
d156c23
@devincowan devincowan mentioned this issue May 13, 2024
Merged
5 tasks
@devincowan
Copy link
Contributor Author

PR #5481 will help with this issue but not entirely resolve it.
Due to a bug in the vue-boostrap-typahead plugin we use, one still has to type quite a bit of the entry before it shows as a suggestion:
image

vue-boostrap-typahead is deprecated.
The best fix would be to upgrade to vue-bootstrap-autocomplete but that module is only available as ESM so would require its own build (as we do with hs_discover).

devincowan added a commit that referenced this issue May 13, 2024
@devincowan
[#5404] note about vue-bootstrap-typeahead deprecation
32eb18d
@devincowan devincowan moved this from In Progress to In Review in HydroShare Issue Management Board May 13, 2024
devincowan added a commit that referenced this issue May 21, 2024
@devincowan
Merge pull request #5481 from hydroshare/5404-funding-agencies
b18960d 
[#5404] Update funding agency app to limit queries to United States
@devincowan devincowan moved this from In Review to Merged in HydroShare Issue Management Board May 21, 2024
@devincowan devincowan mentioned this issue May 21, 2024
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devincowan devincowan

Labels
bug Broad category when more specific Label can't be found enhancement Pages and General HS Components Resource Landing Page resource landing page issues
Projects
HydroShare Issue Management Board
Merged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5404] Update funding agency app to limit queries to United States hydroshare/hydroshare
1 participant
@devincowan