Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups photo icon fails to update #5382

Closed
ClaraCogswell opened this issue Feb 28, 2024 · 3 comments · Fixed by #5389
Closed

Groups photo icon fails to update #5382

ClaraCogswell opened this issue Feb 28, 2024 · 3 comments · Fixed by #5389
Assignees
Labels
bug Broad category when more specific Label can't be found Groups

Comments

@ClaraCogswell
Copy link

Description of the bug
When uploading a photo to be the icon of a group, the upload it possible but the changes are not reflected when the changes are saved.

Steps to reproduce the bug:

  1. Go to [https://www.hydroshare.org/group/250]
  2. Click on 'Owner settings
  3. Scroll down to add a photo
  4. attempt upload, see failure

Expected behavior
should upload the photo and display it on the landing page.

Additional information
Bug noticed by Dan Ames

@ClaraCogswell ClaraCogswell added the bug Broad category when more specific Label can't be found label Feb 28, 2024
@ClaraCogswell ClaraCogswell added this to Backlog in HydroShare Issue Management Board via automation Feb 28, 2024
@devincowan devincowan self-assigned this Feb 28, 2024
@devincowan devincowan moved this from Backlog to In Progress in HydroShare Issue Management Board Feb 28, 2024
@devincowan
Copy link
Contributor

Tested locally, works as expected
image

Looking into explanation...

@devincowan
Copy link
Contributor

devincowan commented Feb 29, 2024

From what I can tell, group images (along with community images) were broken when we upgraded our STATIC settings in 2.0 release
#4738

I built the original implementation just to make sure
#2637
https://github.com/hydroshare/hydroshare/pull/4612/files

Relevant issue
jazzband/sorl-thumbnail#568

@devincowan
Copy link
Contributor

scratch that, this is an undocumented issue with sorl-thumbnail due to Pillow version.

Dropping Pillow back to 9.3.0
hydroshare/hs_docker_base@7a6c581

@devincowan devincowan moved this from In Progress to In Review in HydroShare Issue Management Board Feb 29, 2024
devincowan added a commit that referenced this issue Mar 1, 2024
[#5382] downgrade Pillow for community/group photos
@devincowan devincowan moved this from In Review to Merged in HydroShare Issue Management Board Mar 4, 2024
@devincowan devincowan mentioned this issue Mar 4, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broad category when more specific Label can't be found Groups
Projects
Development

Successfully merging a pull request may close this issue.

2 participants