-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce file quota #5228
Comments
Some places we need to check enforcement: file addhttps://github.com/hydroshare/hydroshare/blob/2.8.1/hs_core/hydroshare/utils.py#L987 Resource createhttps://github.com/hydroshare/hydroshare/blob/master/hs_core/hydroshare/utils.py#L832 Resource copyI don’t think that we validate before starting the copy, we just probably throw an exception during the copying process Resource versionDoesn’t look like we validate before copying
Owner transferhttps://github.com/hydroshare/hydroshare/blob/2.8.1/hs_core/models.py#L2340 Replicate bag or ingest from userzonehttps://github.com/hydroshare/hydroshare/blob/2.8.1/hs_core/tasks.py#L695 Add url file to reshttps://github.com/hydroshare/hydroshare/blob/master/hs_core/views/resource_folder_hierarchy.py#L553 Unzip (via UI and API)Tested, looks like this is currently permitted even for user that is over quota. API file addEndpoints look like they use the resource_file_add_pre_process which calls validate_user_quota |
The migrations `0080_baseresource_quota_holder.py`, `0080_resourcefile_filesize_cache_updated.py`, `0081_alter_baseresource_quota_holder.py`, and `0082_merge_20240509_1646.py` are no longer needed and have been deleted. These migrations were related to the `baseresource` model's `quota_holder` field and the `resourcefile` model's `filesize_cache_updated` field. The changes made in these migrations have been consolidated into a new migration `0080_baseresource_quota_holder_squashed_0082_merge_20240509_1646.py`, which adds both fields to their respective models.
Describe the feature you'd like and what it will do
File quota system was implemented circa #1566.
However, the quota has not been enforced -- warning notifications are provided but to date users have been permitted to exceed their quota allotments.
Doc used to date: https://docs.google.com/document/d/1OxrX4qPkeYsU0WPu7BMODakCcvSumidallXZjFpnkgo/edit?usp=sharing
We need to turn quota enforcement on.
This will include:
Policy Decisions
Different quota thresholds for .edu and .gov emails?HS Development Tasks
If no downloads within a year, should we "offboard" a resource's zipped bagit archive #5310created a separate issue for thisAdd the ability to move instead of copy from UserZone to DataZone #5318created a separate issue for thisDevops Tasks
Add the rules that exist on the beta dataZone to the beta userZoneAfter additional testing, create a dot release checklist for deployment of the new engine, msi, and rule on productionIrods Development Tasks
Ensure microservice "behaves" (ideally this would include performance enhancement for multiple file deletion)we decided to defer the iRods upgrades until after this issues is releasedCheck user quota before uploading files to iRods userZone #5329 (this could be done with rules or with the internal iRods quota system. However, at this time we have decided to instead just notify support if a user that has already exceeded quota continues to upload to the userZone)we have also decided to defer this work.Messaging and Documentation
The text was updated successfully, but these errors were encountered: