Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Error occured when calling imagethumbnails" message #348

Open
barryrowlingson opened this issue Oct 4, 2021 · 1 comment
Open

"Error occured when calling imagethumbnails" message #348

barryrowlingson opened this issue Oct 4, 2021 · 1 comment

Comments

@barryrowlingson
Copy link

Thumbnailing JPEGs failed with a

20:44:31 hyde Error occured when calling imagethumbnails

This line:

im = im.convert('RGBA')

hyde converts the PIL image to RGBA, but that fails with Pillow after v3.7 because it was deprecated and then removed:

python-pillow/Pillow@193c756

with the advice to convert to RGB before saving. I think the solution for hyde is to not convert to RGBA on line 295 for JPEG files.

short diff attached tests and only converts non-JPEG to RGBA.

diff.txt

(Let me know if you'd rather I did a fork and PR, but its about two lines!)

@navilan
Copy link
Member

navilan commented Oct 5, 2021

(Let me know if you'd rather I did a fork and PR, but it's about two lines!)

Yes, please. Please note: Hyde has been unmaintained for quite sometime though. I still use it in a few of my projects and I know it's still used elsewhere.

barryrowlingson added a commit to barryrowlingson/hyde that referenced this issue Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants