Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to append to plugin list when inheriting config #256

Open
tasn opened this issue Mar 4, 2014 · 3 comments
Open

Make it possible to append to plugin list when inheriting config #256

tasn opened this issue Mar 4, 2014 · 3 comments
Milestone

Comments

@tasn
Copy link

tasn commented Mar 4, 2014

I've created the new HtmlMin plugin. For convenience, this should only be used in production, however, I can't add the plugin, because I can't append to the list when inheriting.

I could just turn the plugin off using it's own config in the development site.yaml, and then enable it in the production, but that's ugly. :)

@navilan
Copy link
Member

navilan commented Mar 4, 2014

Hi,
Hyde 1.0 will have patchable configuration. That said, this particular use case has been addressed within the plugins themselves. See the uglify plugin for example:
https://github.com/hyde/hyde/blob/master/hyde/ext/plugins/js.py#L53-L55

@tasn
Copy link
Author

tasn commented Mar 4, 2014

Patched configuration would be better, but sure, one could just adjust the plugins to not do it on development mode. I wanted to avoid this for HtmlMin, I could add it if wanted.

@navilan
Copy link
Member

navilan commented Mar 4, 2014

Yeah, one of the design goals for hyde (this edition as opposed to 0.5 edition at lakshmivyas/hyde) has been to simplify the plugins to be a simple list.

Handling development vs production, their own configuration etc have been a part / side effect of this decision. So far, I have not found any issues with that.

@llonchj llonchj added this to the Version 1.0.0 milestone May 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants