Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeneratePathProperty got lost during conversion #278

Open
rednaxLamington opened this issue Jun 29, 2020 · 2 comments
Open

GeneratePathProperty got lost during conversion #278

rednaxLamington opened this issue Jun 29, 2020 · 2 comments

Comments

@rednaxLamington
Copy link

rednaxLamington commented Jun 29, 2020

In the old csproj format file a package was included using:
<PackageReference Include="Graphviz" GeneratePathProperty="true"> <Version>2.38.0.2</Version> </PackageReference>

In the new format this is formatted as :
<PackageReference Include="Graphviz" Version="2.38.0.2"/>
It should be:
<PackageReference Include="Graphviz" Version="2.38.0.2" GeneratePathProperty="true"/>

The GeneratePathProperty is needed to included package items to the project (for example):
<Content Include="$(PkgGraphviz)\zlib1.dll"> <Link>GraphViz\zlib1.dll</Link> <CopyToOutputDirectory>Always</CopyToOutputDirectory> </Content>

@mungojam
Copy link
Collaborator

Are you sure that it is still needed? I think I have seen those properties get defined automatically in the auto-generated files in the obj folder when using the new project format.

I've also consumed them too

@rednaxLamington
Copy link
Author

That is a really good question. I can only answer that by trying.

But either way, the GeneratePathProperty is supported in both formats, so it seems logical to me to convert that attribute too. Right now my projects are failing because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants