"Entity framework was detected" false positive

[jzabroski]

The following code is extremely annoying for me. I am the co-maintainer of FluentMigrator, a migration framework that uses a project structure that may or may not contain the folder name Migrations.

What are you trying to achieve here? Why can't you just check the Project and packages.config for references to the EntityFramework6 package?

CsprojToVs2017/Project2015To2017.Core/UnsupportedProjectTypes.cs

Lines 33 to 38 in e33ca10

	// Code-first
	if (project.ProjectFolder.EnumerateDirectories().Any(x =>
	string.Equals(x.Name, "Migrations", StringComparison.OrdinalIgnoreCase)))
	{
	return true;
	}

I also think, if you're going to raise an ERR level here, you should explain what you're checking in the error message.

[mungojam]

Fair point, we should fix this

[redwyre]

I have the same issue, could use an override to ignore it. Renaming the folder before converting and back after works though.

[jzabroski]

Yeah, I rename it to Mygrations, ugh.

[mpawelski]

If someone plan to work on it then it's worth noting that since EF 6.3 migrating to new .csproj is possible

From https://docs.microsoft.com/en-us/ef/ef6/what-is-new/#ef-630

The migrations commands have been rewritten to execute out of process and work with SDK-style projects.

I was able to successfully migrate to new csproj by:

1. Comment out the code that checks for "Migration" directory or "edmx" files. (If you don't want change CsprojToVs2017 then renaming "Migrations" to "Mygrations" trick should work too)
2. Running dotnet .\Project2015To2017.Migrate2017.Tool\bin\Debug\netcoreapp2.1\dotnet-migrate-2017.dll migrate --no-backup C:\projects\MyOldProjectWithOldCsproj
3. Removing "<Compile Update=" and "<EmbeddedResource Update=" from project with EF migrations. I used this regexes (replace the match with empty string):

<Compile Update="Migrations\\(.|[\s\n])+?<\/Compile>[\n\s]+
<EmbeddedResource Update="Migrations\\(.|[\s\n])+?<\/EmbeddedResource>[\n\s]+

4. Add <EmbeddedResourceUseDependentUponConvention>true</EmbeddedResourceUseDependentUponConvention> to EF's .csproj or Directory.Build.props file. Without this change I had this error:

"Could not find any resources appropriate for the specified culture or the neutral culture. Make sure "MyOldProjectWithOldCsproj.Migrations.TestMigrationEmpty.resources" was correctly embedded or linked into assembly "MyOldProjectWithOldCsproj" at compile time, or that all the satellite assemblies required are loadable and fully signed."

And it seems that everything works. When I add migration with Add-Migration in VS new migrations files are added without changing .csproj.

Hope this will help some people struggling with migration to new .csproj.

[dahlbyk]

@hvanbakel if you're still willing to accept changes to this project, I'd be willing to put together a PR to migrate to EmbeddedResourceUseDependentUponConvention for projects with EF 6.3+.

[jzabroski]

@dahlbyk In my experience, with open source, just do it and there is a decent chance it gets merged or forked. Especially now with GitHub Actions its super easy to fork projects like these if the maintainer is falling behind supporting PRs.

[hvanbakel]

I can still pick up and merge prs, it’s just a matter of time, a project like this is never truly finished.

…

On Mon, Jan 18, 2021 at 14:16 John Zabroski ***@***.***> wrote: @dahlbyk <https://github.com/dahlbyk> In my experience, with open source, just do it and there is a decent chance it gets merged or forked. Especially now with GitHub Actions its super easy to fork projects like these if the maintainer is falling behind supporting PRs. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#262 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7QKPFU7GT2ACQ4LZOZ22TS2SXLHANCNFSM4IXT2VUA> .