Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile issues using newer NPM #30

Open
justinm opened this issue Mar 22, 2022 · 1 comment
Open

Compile issues using newer NPM #30

justinm opened this issue Mar 22, 2022 · 1 comment

Comments

@justinm
Copy link

justinm commented Mar 22, 2022

This issue seems to be deep inside of libnpmpack, specifically const destination = path.resolve(opts.packDestination, filename) on line 43 of lib/index.js. opts.packDestination is undefined. Adding a ?? "" fixes my issue locally.```

➤ YN0000: [@ldk/pipelines]: Error: Command (npm pack "/home/runner/work/ldk-pipelines/ldk-pipelines/packages/@ldk/pipelines") failed with status 1:
➤ YN0000: [@ldk/pipelines]: #STDERR> npm ERR! code ERR_INVALID_ARG_TYPE
➤ YN0000: [@ldk/pipelines]: #STDERR> npm ERR! The "path" argument must be of type string. Received undefined
➤ YN0000: [@ldk/pipelines]: #STDERR>
➤ YN0000: [@ldk/pipelines]: #STDERR> npm ERR! A complete log of this run can be found in:
➤ YN0000: [@ldk/pipelines]: #STDERR> npm ERR! /home/runner/.npm/_logs/2022-03-22T04_51_05_023Z-debug.log
➤ YN0000: [@ldk/pipelines]: #STDERR>
➤ YN0000: [@ldk/pipelines]: #STDOUT>
➤ YN0000: [@ldk/pipelines]: at ChildProcess. (/home/runner/work/ldk-pipelines/ldk-pipelines/node_modules/jsii-pacmak/lib/util.js:178:27)
➤ YN0000: [@ldk/pipelines]: at Object.onceWrapper (node:events:640:26)
➤ YN0000: [@ldk/pipelines]: at ChildProcess.emit (node:events:520:28)
➤ YN0000: [@ldk/pipelines]: at maybeClose (node:internal/child_process:1092:16)
➤ YN0000: [@ldk/pipelines]: at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)

@justinm justinm changed the title jsii-pakmac no longer supports --no-npmignore on newer versions of NPM Compile issues using newer NPM Mar 22, 2022
@justinm
Copy link
Author

justinm commented Mar 22, 2022

Note: This appears only when cdkdx is used with npx. This definitely feels like an upstream issue..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant