Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error overlay #5

Open
shuding opened this issue Apr 27, 2022 · 2 comments
Open

Error overlay #5

shuding opened this issue Apr 27, 2022 · 2 comments

Comments

@shuding
Copy link
Collaborator

shuding commented Apr 27, 2022

It should support displaying error overlay (for both compilation and runtime errors) inside the iframe and send back the error with stack to the main window.

@huozhi
Copy link
Owner

huozhi commented Apr 28, 2022

Could also be a good chance to drop the returned error property. for sending back the error we might need to return a callback setter to receive it? Like

{ onError } = useLiveCode(files)

onError((e) => {
  ...
})

@shuding
Copy link
Collaborator Author

shuding commented May 4, 2022

I think it should either take an onError callback as the argument or return an error value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants