feat: loading indicator #523
Conversation
| @@ -59,6 +59,7 @@ | |||
| "arg": "^5.0.2", | |||
| "clean-css": "^5.3.3", | |||
| "magic-string": "^0.30.8", | |||
| "ora": "^5.4.1", | |||
There was a problem hiding this comment.
ora v6 and above is native ESM, where @swc-node/register breaks.
Tried @swc-node/register/esm and @swc-node/register/esm-register but AFAIU those are target for esm projects, and it also breaks in current project settings.
A bit lazy solution but since we're using a simple indicator, we can stick to v5.4.1 IMO.
| const spinner = ora({ | ||
| text: 'bundling...\n\n', | ||
| spinner: 'dots', | ||
| color: 'green', | ||
| }) |
There was a problem hiding this comment.
LMK how you'd like the output to behave.
Current:
Screen.Recording.2024-04-26.at.3.11.49.PM.mov
| try { | ||
| spinner.start() |
There was a problem hiding this comment.
We could use oraPromise, but it outputs a green checkmark where it can't be opted-out by default.
|
Fantastic!! 😮😮😮😮😮😮😮😮😮😮😮😮😮😮😮😮😮 |
|
@devjiwonchoi I found sometimes it swallow the content. I think we need to stop before we log everything in output plugin |
|
Revert atm for patch |
|
Got it!! Will investigate further! |
Closes #512