Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enharmonics getting cut short #207

Open
brubsby opened this issue Jan 31, 2020 · 1 comment
Open

Enharmonics getting cut short #207

brubsby opened this issue Jan 31, 2020 · 1 comment

Comments

@brubsby
Copy link

brubsby commented Jan 31, 2020

I think I may have found a corner case related to #59, or an unusual behavior if not.

Seems the midi off doesn't get re-fired if the notes are enharmonics (or at least enharmonics based on the transpose table, haven't checked other cases), and the second and third A-2 midi get cut off before their note duration is finished:

Orca snippet:

.............................
.1i2.........................
1V0..........................
.............................
...V1........................
...0F0.......................
....*HHHHHHHHHHHHHHHHHHHHHHHH
.15og..................H.....
...V1........................
...0F1.......................
.....HHHHHHHHHHHHHHHHHHHHHHHH
.11ogA.....H.................
.2Co.........................
..eoT..................H.....
.62X.........................
.............................
....1D2......................
.....*:00..f.................

Renoise midi log:
image

Non-enharmonic version:

.............................
.1i2.........................
1V1..........................
.............................
...V1........................
...1F0.......................
.....HHHHHHHHHHHHHHHHHHHHHHHH
.15og..................A.....
...V1........................
...1F1.......................
....*HHHHHHHHHHHHHHHHHHHHHHHH
.11ogA.....A.................
.2Co.........................
..0oTA.....A.................
.62XA........................
.............................
....1D2......................
......:00A.f.................

Renoise midi log:
image

Only stumbled into this because I wasn't fully aware of how the transpose notation worked and could easily work around it in my current patch, but thought you might want to change the behavior in this situation.

@neauoire
Copy link
Member

Thanks for the head's up, I'm trying to figure out how to solve this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants