Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout when closing a WebSocket connection #46

Open
Joannis opened this issue Mar 26, 2024 · 1 comment
Open

Add timeout when closing a WebSocket connection #46

Joannis opened this issue Mar 26, 2024 · 1 comment

Comments

@Joannis
Copy link
Contributor

Joannis commented Mar 26, 2024

The server MUST close the underlying TCP
connection immediately; the client SHOULD wait for the server to
close the connection but MAY close the connection at any time after
sending and receiving a Close message, e.g., if it has not received a
TCP Close from the server in a reasonable time period.

I think we're currently not closing the connection at all if a server keeps it open.

@adam-fowler
Copy link
Member

adam-fowler commented Mar 26, 2024

It is up to the server to initiaite the TCP connection closure. Once it has initiated it, the inbound on the client will finish and the client will close its connection. The RFC is pretty clear the client should not initiate a TCP connection closure. But we could add a timeout I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants