Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drama Page #681

Open
1 of 4 tasks
NuckChorris opened this issue Oct 11, 2015 · 1 comment
Open
1 of 4 tasks

Drama Page #681

NuckChorris opened this issue Oct 11, 2015 · 1 comment
Milestone

Comments

@NuckChorris
Copy link
Member

NuckChorris commented Oct 11, 2015

Creation of the drama page.

  • API
  • Design
  • Implementation
  • Functionality
@NuckChorris
Copy link
Member Author

The Drama resource is an easy one to create, if anyone wants to jump on the API portion of this. It should be almost identical to the Anime resource (model, controller, serializer, etc.), with common elements dragged out into the Media and Titleable concerns.

The Titleable concern currently requires an original ja_en title, which obviously doesn't work for the korean dramas (or for existing manwha in our manga db, for that matter). This will need fixing, and there will need to be a before_create hook to pick which title should be canonical — it's clear that the existing "just pick ja_en" won't actually work. Perhaps the following:

If there's an English title, use that
Else if there's a title for #{country}_en, use that
Else just use the first one

We should probably add a "country of origin" column containing ISO-3166-1 Alpha 2 codes

Anyways, after the DB is created, there's a bunch of JSON files which need an import script written for them, probably a rake task.

@NuckChorris NuckChorris modified the milestone: V3 Nov 30, 2015
@trmcnvn trmcnvn modified the milestones: V3.1, V3 Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants