Icon::get() injection leads to HTML Output

[ArchBlood]

What steps will reproduce the problem?

Currently I'm facing some issues when trying to inject the Icon::get() method for icons through the Verified module, we use the Icon class for the icons within our widget class VerifiedIcon this works with the method of extending an existing widget class through EVENT_CREATE but this also requires us to also extend the existing view as well, I've currently gotten an example of our module to implement this through EVENT_BEFORE_RUN but the issue is that the Icon::get() function won't allow the use case we need.

What is the expected result?

The Icon::get() method should allow to be rendered correctly.

What do you get instead?

HTML output is displayed <i class="fa fa-check-circle tt" title="Verified" aria-hidden="true" role="img" style="color: #458e56;"></i><span class="sr-only">Verified</span>

Additional info

I've tried everything from encoding to decoding even tried multiple hack-ish methods without any ability to use the Icon:get() method in a way so that we don't need to rely on core view manipulation through EVENT_CREATE.

Q	A
HumHub version	1.16.0-beta.2
PHP version	8.1.18
Operating system	CloudLinux

Note: Also provide the full error stacks from Administration --> Information --> Logging and errors from your browser console if possible.
Note: Please use the community site for any questions on customizing HumHub.

[ArchBlood]

For better understanding of what I mean here's the screenshot of how it's rendered;

As you'll see it's injected correctly but the output is returned as HTML due to Icon::get()

User Profile

Space

[ArchBlood]

A simple solution would be removing Html::encode() from the view file, I don't really see any need for it anymore but if the HumHub staff still think it's needed we'll have to find another possible solution which requires looking into the Icon::get() method.

humhub/protected/humhub/modules/content/widgets/views/containerProfileHeader.php

Line 55 in 619191f

<h1 class="<?= $classPrefix ?>"><?= Button::asLink(Html::encode($title))->link($container->getUrl()) ?></h1>

[yurabakhtin]

@ArchBlood I think the Html::encode() is used there in order to avoid js script like this:

[felixhahnweilheim]

Yes, but it could be moved from the view file into the widget class (init() function) where $title is defined.

[yurabakhtin]

@felixhahnweilheim Yes, you are right, I have done this in the PR #6955.
@ArchBlood After the PR you can append an icon to a title in the event EVENT_BEFORE_RUN.
@luke- Please merge it.

[ArchBlood]

@felixhahnweilheim Yes, you are right, I have done this in the PR #6955. @ArchBlood After the PR you can append an icon to a title in the event EVENT_BEFORE_RUN. @luke- Please merge it.

Works very well for the needed use case.

[luke-]

PR is mreged.