Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database integrity checks for ContentContainer in the spacemodule #6900

Open
marc-farre opened this issue Mar 25, 2024 · 3 comments
Open

Comments

@marc-farre
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

If a space is deleted in the database, but for some reason, the related ContentContainer is not deleted, running a DB integrity check should delete it.

E.g: https://community.humhub.com/content/perma?id=276362

Describe the solution you'd like

Add integrity checks in the space module similar to:

@marc-farre
Copy link
Collaborator Author

I'm not sure about this issue, because DB integrity check seams to have fixed the issue in fact: https://community.humhub.com/comment/perma?id=48400

When exploring the code, I still think this integrity check for the space module should be added, but maybe it's already somewhere else?

@luke-
Copy link
Contributor

luke- commented Mar 25, 2024

I can't find the check straight away either.

We should add a check here and loop over all "ContentContainers" and check whether the target is still correct.

https://github.com/humhub/humhub/blob/master/protected/humhub/modules/content/Events.php#L93

@marc-farre What do you think?

@marc-farre
Copy link
Collaborator Author

Yes, I also thought about checking in the content module (this is where I searched first).
In this case, we can remove so checks in the user module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants