Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In spaces, allow viewing the old approval messages in the “Manage members” page #6880

Open
marc-farre opened this issue Mar 8, 2024 · 3 comments

Comments

@marc-farre
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

When users request to join a Space, they write a request message.
Once the user is approved, this message stays in the database, but cannot be seen from the UI.
Some admins would like to be able to view this membership request messages history.

Describe the solution you'd like

Add a page such as “Approvals history” or something like that in the Space “Manage members” section similar to the "Pending approval".

Original discussion

https://community.humhub.com/s/general-discussion/post/post/view?id=16368
But I also had this request from other admins in the past.

@luke-
Copy link
Contributor

luke- commented Mar 8, 2024

Hmm, I don't think we need a separate page for this. But perhaps more details could be displayed in the member list?

Maybe we could add a modal with details?

e.g.

  • Approval Message
  • Approved by

image

What do you think? What could we display there if there is no space approval enabled?

@marc-farre marc-farre changed the title Add a page in the Space “Manage members” section to view membership request messages history In spaces, allow viewing the old approval messages in the “Manage members” page Mar 8, 2024
@marc-farre
Copy link
Collaborator Author

Yes, that's much better!

What could we display there if there is no space approval enabled?

As there could be previous approvals even if not enabled (if the space settings were changed), maybe we could display this new column only if at least one member has an approval message?

The problem by adding a column is that tables are not well responsive. With the current table, if the screen width is less than 450px, we cannot delete a member:
image

@luke-
Copy link
Contributor

luke- commented Mar 8, 2024

@marc-farre I've added this to our design tasks. Maybe we could improve the UI here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants