Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import() fails when using CommonJS version #6

Closed
nzakas opened this issue Aug 17, 2022 · 3 comments · Fixed by #11
Closed

import() fails when using CommonJS version #6

nzakas opened this issue Aug 17, 2022 · 3 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@nzakas
Copy link
Contributor

nzakas commented Aug 17, 2022

Rollup is replacing import() with require(), which causes an error when attempting to import an ESM module from a CommonJS module.
@nzakas nzakas added the bug Something isn't working label Aug 17, 2022
@JounQin
Copy link

JounQin commented Aug 18, 2022

Hi, what is the difference with import(specifier) directly?

@nzakas
Copy link
Contributor Author

nzakas commented Aug 18, 2022

Sorry, I’m not sure what you’re asking.

@nzakas nzakas closed this as completed in cf54a0b Aug 18, 2022
@github-actions github-actions bot mentioned this issue Aug 18, 2022
Merged
@JounQin
Copy link

JounQin commented Aug 18, 2022

Sorry, I’m not sure what you’re asking.

Sorry if my question is confusing.

I'm just wondering what problem is this module resolving. 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 1.0.1 humanwhocodes/module-importer
2 participants
@nzakas @JounQin