Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo at Remove Cookie code snippet #31

Open
viniaxt opened this issue May 14, 2022 · 0 comments
Open

Typo at Remove Cookie code snippet #31

viniaxt opened this issue May 14, 2022 · 0 comments

Comments

@viniaxt
Copy link

viniaxt commented May 14, 2022

Hey,

I've noticed a typo at "remove cookie" method. It states:

this.write(name, '', -1, '/');

But, if you look carefully, the 4th parameter of our "write cookie" function is "domain", not "path". So, the correct snippet should look something like this:

this.write(name, '', -1, undefined, '/');

This mistake caused the "remove cookie" function to not remove the cookie.

Hope you guys get it fixed as soon as possible so people can have a correct code snippet 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant