Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In RocketChat seen keeps track of DMs and private rooms #20

Open
stevenmcastano opened this issue May 21, 2019 · 1 comment
Open

In RocketChat seen keeps track of DMs and private rooms #20

stevenmcastano opened this issue May 21, 2019 · 1 comment

Comments

@stevenmcastano
Copy link

Can this be set to only look at public channels, or only respond with channels if the person asking is also in that channel?

@strugee
Copy link
Member

strugee commented May 27, 2019

Hm, it should be doing that already, at least for PMs. See https://github.com/hubot-scripts/hubot-seen/blob/1f94663f2d5c2947d89a3ffc84111968e6757722/src/seen.coffee#L20

Without actually looking my guess is that the RocketChat adapter doesn't support the message.user.pm property, which we need to detect PMs. As for private rooms honestly I have no idea what the story is there. We'd need the adapter to give us some flag that indicated the room was private. It's possible that already exists; I haven't looked. If I get some time I will but no promises! If you find something though I don't see why we couldn't add support for it to hubot-seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants