Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request fails with Something went really wrong: Error: DEPTH_ZERO_SELF_SIGNED_CERT #14

Open
kennyg opened this issue Aug 19, 2015 · 3 comments

Comments

@kennyg
Copy link

kennyg commented Aug 19, 2015

we use self-signed certs with an internal circleci instance. the requests fail with this error

request fails with Something went really wrong: Error: DEPTH_ZERO_SELF_SIGNED_CERT

workaround is to add this setting: process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0"

@dylanlingelbach
Copy link
Contributor

@kennyg - any suggestions on what we should do other than the workaround you suggest?

I don't think handling this in the code makes sense in general, for security reasons.

@kennyg
Copy link
Author

kennyg commented Aug 21, 2015

@dylanlingelbach It's not a great suggestion, but, perhaps an environment variable to allow self signed certs? the circleci instance i'm using is hosted internally and uses a self-signed cert.

I found the workaround via this link, request/request#418

@dylanlingelbach
Copy link
Contributor

@kennyg - I would need to test that passing rejectUnauthorized: false to the requests would work. But what is the advantage to an environment variable for that instead of just setting process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants