Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for External Group operations #1835

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mestebangutierrez
Copy link

@mestebangutierrez mestebangutierrez commented Apr 20, 2024

Description

Provide support for External Group operations, in particular:

  • List external groups in an organization
  • Get an external group
  • List a connection between an external group and a team
  • Connect an external group to a team
  • Remove connection between an external group and a team

Fixes #1828

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (c5ce1f6) to head (8c859c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1835      +/-   ##
============================================
+ Coverage     80.64%   80.96%   +0.31%     
- Complexity     2358     2403      +45     
============================================
  Files           225      233       +8     
  Lines          7203     7323     +120     
  Branches        395      399       +4     
============================================
+ Hits           5809     5929     +120     
  Misses         1149     1149              
  Partials        245      245              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mestebangutierrez mestebangutierrez force-pushed the support-external-groups branch 3 times, most recently from adad47f to 934f72a Compare May 2, 2024 09:23
@mestebangutierrez
Copy link
Author

  • Rebased from main
  • Added additional tests to improve coverage
  • Removed unnecessary code (e.g., unrequired bridge methods)
  • Minor improvements (make parameters & variables final where possible, define serialVersionUID for serializable classes)

@mestebangutierrez
Copy link
Author

@bitwiseman, is anything else required on my side before continuing the contribution process?

@jbenaventem
Copy link
Contributor

jbenaventem commented May 26, 2024

@bitwiseman Please take a moment to review this Pull Request. It contains important changes that could significantly improve the GitHub Enterprise accounts use. If you notice any issues or have any concerns, do not hesitate to comment. Your feedback is greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Handle supports for the External Groups endpoints
2 participants