Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XML formatter #443

Closed
5 tasks
jkbrzt opened this issue Feb 28, 2016 · 1 comment
Closed
5 tasks

Fix XML formatter #443

jkbrzt opened this issue Feb 28, 2016 · 1 comment
Labels
bug Something isn't working

Comments

@jkbrzt
Copy link
Member

jkbrzt commented Feb 28, 2016

Issues

The existing implementation of XML formatting suffers from multiple issues:

Possible Solutions

  1. Find/implement a robust XML formatter
  2. Remove XML formatting all together Remove XML pretty-print formatting. Fixes #389. #394
  3. Only format simple XML without comments, processing instructions, doctype, and namespaces.

Example

Before:

<?pi data?>
<!-- comment -->
<root xmlns='namespace'>
   <element key='value'>text</element>
   <element>text</element>tail
   <empty-element/>
</root>

After:

<ns0:root xmlns:ns0="namespace">
    <ns0:element key="value">text</ns0:element>
    <ns0:element>text</ns0:element>tail
   <ns0:empty-element />
</ns0:root>
@jkbrzt jkbrzt added the bug Something isn't working label Feb 28, 2016
@jkbrzt jkbrzt closed this as completed in 714b560 Mar 18, 2016
jkbrzt added a commit that referenced this issue Mar 18, 2016
Closes #443
Closes #389
Closes #415
Closes #384
Closes #394
@jkbrzt
Copy link
Member Author

jkbrzt commented Mar 18, 2016

Removed the XML formatter for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant