Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow underscores in hostnames #7206

Open
george-wilson-rea opened this issue Jul 11, 2023 · 0 comments
Open

Disallow underscores in hostnames #7206

george-wilson-rea opened this issue Jul 11, 2023 · 0 comments
Labels
bug Determined to be a bug in http4s uri raze it and salt the earth whence it grew

Comments

@george-wilson-rea
Copy link
Contributor

ip4s does not allow underscores in hostnames, which seems to be the correct behaviour. It would be helpful if http4s would update its URI representation to disallow underscores as well (allowing only alphanumeric characters and hyphens). This caused me a pretty hard-to-track-down problem while using http4s-ember. It would be helpful if there were better messaging around the MissingHost() error in ClientHelpers
@armanbilge armanbilge added uri raze it and salt the earth whence it grew bug Determined to be a bug in http4s labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Determined to be a bug in http4s uri raze it and salt the earth whence it grew
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@armanbilge @george-wilson-rea