Uri: inconsistent query param names (url-encode) when .renderString-ing

[yurique]

Uri seems to behave differently depending on where it "comes" from. Here's an example:

scala> import org.http4s._
import org.http4s._

scala> val uri = Uri.fromString("https://site.nowhere/?with:colon=abc").toOption.get
val uri: org.http4s.Uri = https://site.nowhere/?with:colon=abc

scala> val copy = uri.copy(query = Query.empty).setQueryParams(uri.multiParams)
val copy: org.http4s.Uri = https://site.nowhere/?with%3Acolon=abc

scala> uri.renderString
val res0: String = https://site.nowhere/?with:colon=abc

scala> copy.renderString
val res1: String = https://site.nowhere/?with%3Acolon=abc

scala> uri.query.params
val res2: Map[String,String] = Map(with:colon -> abc)

scala> copy.query.params
val res3: Map[String,String] = Map(with:colon -> abc)

scala> uri == copy
val res4: Boolean = true

scala> uri.query == copy.query
val res5: Boolean = true

scala> uri.renderString == copy.renderString
val res6: Boolean = false

scala> uri.query == copy.query
val res7: Boolean = true

scala> uri.query.renderString == copy.query.renderString
val res8: Boolean = false

The biggest thing here is that two equal (==) queries produce different results with .renderString.

Another thing I'd argue - the colon (:) should not be url-encoded in this case (at least my quick googling of it suggests so). There might be other character not covered by org.http4s.internal.UriCoding#QueryNoEncode that should also not be url-encoded.

[tothpeti]

I am new to OSS contributing, but I would like to work on this issue.

[armanbilge]

@tothpeti welcome, thank you! feel free to ask any questions here or on Discord and I encourage you to put up a draft PR very very early (e.g. just start by adding some failing tests) so everyone can follow along your progress and help where we can :)

[tothpeti]

Unfortunately, I haven't been able to make any noticable progression with the ticket since I picked it up. This is why I will unassign myself from it.