Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request decompression middleware #7072

Open
matkob opened this issue Apr 18, 2023 · 4 comments · May be fixed by #7119
Open

Add request decompression middleware #7072

matkob opened this issue Apr 18, 2023 · 4 comments · May be fixed by #7119

Comments

@matkob
Copy link

matkob commented Apr 18, 2023

Hello everyone!

I'm using GZip middleware in one of the projects and recently realized that it only supports response compression. My idea is to either add an extra capability to decompress the requests as well, or create another middleware for that.

What do you think? I've already written the code and it can be merged with current GZip implementation fairly easily.
@armanbilge
Copy link
Member

Yup, contribution would be welcome here! :) We might have some similar issues / stale PRs lying around, can't remember, but no matter, happy to see this land. Thanks!

@rossabaker
Copy link
Member

Related and stale discussion on #4981.

@matkob
Copy link
Author

matkob commented Apr 18, 2023

Thank you for the link, I'll catch up and prepare the code.
I saw bunch of open discussions there and am wondering what would be the preferred way for future ones, shall I continue here or move to the old one?

@rossabaker
Copy link
Member

I'd say if it's related to that ticket, we can keep discussing there, where there's more research, even if it's old. Thanks!

@matkob matkob linked a pull request May 17, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add request decompression to server GZip middleware matkob/http4s
3 participants
@rossabaker @armanbilge @matkob