Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter function does not work with non-ASCII characters #1038

Open
Eucyon opened this issue Jun 8, 2022 · 1 comment · May be fixed by #1105
Open

Filter function does not work with non-ASCII characters #1038

Eucyon opened this issue Jun 8, 2022 · 1 comment · May be fixed by #1105
Labels
bug 🐛 Something isn't working
Milestone
3.4.0

Comments

@Eucyon
Copy link

Eucyon commented Jun 8, 2022

To reproduce, press F4 and insert e.g. ä, ö or ü.

Thank you!
@BenBE BenBE added the bug 🐛 Something isn't working label Jun 8, 2022
@BenBE BenBE added this to the 3.2.2 milestone Jun 8, 2022
@fasterit
Copy link
Member

fasterit commented Jun 8, 2022

The getch() we are using has no idea about how to process multi-byte input properly.
See https://github.com/ThomasDickey/dialog-snapshots/blob/7289c6063b40654f9818372cdbb9d17378ccc46a/ui_getc.c#L333 for an example of how to manage this better.
Code from dialog is LGPL v2.1 so compatible. Hint, hint.

adsr added a commit to adsr/htop that referenced this issue Oct 13, 2022
@adsr
Accept wide chars in filter input (htop-dev#1038)
3bca05e 
Notably this doesn't handle wcwidth!=1 or extended grapheme clusters, but you
can filter for your emoji process now.
adsr added a commit to adsr/htop that referenced this issue Oct 13, 2022
@adsr
Accept wide chars in filter input (htop-dev#1038)
cbf47ce 
Notably this doesn't handle wcwidth!=1 or extended grapheme clusters, but you
can filter for your emoji process now.
adsr added a commit to adsr/htop that referenced this issue Oct 13, 2022
@adsr
Accept wide chars in filter input (htop-dev#1038)
de9a278 
Notably this doesn't handle wcwidth!=1 or extended grapheme clusters, but you
can filter for your emoji process now.
adsr added a commit to adsr/htop that referenced this issue Oct 13, 2022
@adsr
Accept wide chars in filter input (htop-dev#1038)
12c49ab 
Notably this doesn't handle wcwidth!=1 or extended grapheme clusters, but you
can filter for your emoji process now.
adsr added a commit to adsr/htop that referenced this issue Oct 14, 2022
@adsr
Accept wide chars in filter input (htop-dev#1038)
71c46d2 
Notably this doesn't handle wcwidth!=1 or extended grapheme clusters, but you
can filter for your emoji process now.
adsr added a commit to adsr/htop that referenced this issue Oct 14, 2022
@adsr
Accept wide chars in filter input (htop-dev#1038)
94b827b 
Notably this doesn't handle wcwidth!=1 or extended grapheme clusters, but you
can filter for your emoji process now.
adsr added a commit to adsr/htop that referenced this issue Oct 14, 2022
@adsr
Accept wide chars in filter input (htop-dev#1038)
6dd3125 
Notably this doesn't handle wcwidth!=1 or extended grapheme clusters, but you
can filter for your emoji process now.
adsr added a commit to adsr/htop that referenced this issue Oct 14, 2022
@adsr
Accept wide chars in filter input (htop-dev#1038)
8060f93 
Notably this doesn't handle wcwidth!=1 or extended grapheme clusters, but you
can filter for your emoji process now.
adsr added a commit to adsr/htop that referenced this issue Oct 16, 2022
@adsr
Accept wide chars in filter input (htop-dev#1038)
e0326d0 
Notably this doesn't handle wcwidth!=1 or extended grapheme clusters, but you
can filter for your emoji process now.
adsr added a commit to adsr/htop that referenced this issue Oct 16, 2022
@adsr
Accept wide chars in filter input (htop-dev#1038)
08af816 
Notably this doesn't handle wcwidth!=1 or extended grapheme clusters, but you
can filter for your emoji process now.
adsr added a commit to adsr/htop that referenced this issue Oct 16, 2022
@adsr
Accept wide chars in filter input (htop-dev#1038)
b90a89e 
Notably this doesn't handle wcwidth!=1 or extended grapheme clusters, but you
can filter for your emoji process now.
adsr added a commit to adsr/htop that referenced this issue Oct 17, 2022
@adsr
Accept wide chars in filter input (htop-dev#1038)
5860ecd 
Notably this doesn't handle wcwidth!=1 or extended grapheme clusters, but you
can filter for your emoji process now.
@BenBE BenBE modified the milestones: 3.2.2, 3.3.0 Feb 3, 2023
@BenBE BenBE linked a pull request Feb 3, 2023 that will close this issue
Accept wide chars in filter input (#1038) #1105
Open
@BenBE BenBE modified the milestones: 3.3.0, 3.4.0 Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

Accept wide chars in filter input (#1038) adsr/htop
3 participants
@BenBE @Eucyon @fasterit