Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gods Eater 2 Audio Bug #19075

Closed
Gelo021 opened this issue Apr 17, 2024 · 5 comments · Fixed by #19095
Closed

Gods Eater 2 Audio Bug #19075

Gelo021 opened this issue Apr 17, 2024 · 5 comments · Fixed by #19095
Labels
Audio
Milestone
v1.18.0

Comments

@Gelo021
Copy link

Gelo021 commented Apr 17, 2024 •
edited

Hi again @hrydgard i just notice that the latest 329 have a audio bug
tested at 1.17.1
https://github.com/hrydgard/ppsspp/assets/67460268/7e184828-bc27-4e2a-9f4c-c23ac0930d5c

tested at 1.17.1-329
https://github.com/hrydgard/ppsspp/assets/67460268/fcc5e95e-b860-4f32-b030-6b2970108ea3

btw its Gods Eater 2
@hrydgard hrydgard added this to the v1.18.0 milestone Apr 18, 2024
@hrydgard hrydgard added the Audio label Apr 18, 2024
@sum2012 sum2012 changed the title Audio Bug Gods Eater 2 Audio Bug Apr 21, 2024
@hrydgard
Copy link
Owner

Interesting! I'll look into it soon. Might be a regression from the Atrac refactorings.

@sum2012
Copy link
Collaborator

sum2012 commented Apr 21, 2024

@hrydgard The buildbot is slow ,I cannot download to test it.
3

@hrydgard
Copy link
Owner

Strange, I just downloaded a couple of builds and it was fine. But I'll look into it.

@Gelo021
Copy link
Author

Gelo021 commented Apr 23, 2024 •
edited

ill try the latest build again

Tested 1.17.1-334

Record_2024-04-24-01-36-58_2f85358b2198d26f8aca533d68bee793.mp4

hrydgard added a commit that referenced this issue Apr 29, 2024
@hrydgard
Add back a lost-in-refactoring hack for the SasAudio/sceAtrac integra…
917f589 
…tion.

Fixes #19075
@hrydgard hrydgard mentioned this issue Apr 29, 2024
Merged
@hrydgard
Copy link
Owner

Latest build has the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Audio
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging a pull request may close this issue.

Add back a hack for the SasAudio/sceAtrac integration (mono audio). hrydgard/ppsspp
3 participants
@hrydgard @sum2012 @Gelo021