Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffers are only added and not removed #55

Open
patrickeibl opened this issue Jul 26, 2022 · 1 comment · May be fixed by #56
Open

Buffers are only added and not removed #55

patrickeibl opened this issue Jul 26, 2022 · 1 comment · May be fixed by #56

Comments

@patrickeibl
Copy link

patrickeibl commented Jul 26, 2022 •
edited

source._get_buffers calls opts.get_bufnrs() to get the buffers for indexing. It checks if each buffer is in buffers and adds it if it's not there. It fails to remove buffers that were not returned from opts.get_bufnrs().

I was experiencing the performance issues described in #40 and this was the cause. The number of indexed buffers only grows, regardless of what get_bufnrs() returns.
@patrickeibl
Copy link
Author

I'm testing a change to call close() on any buffers in self.buffers that are not returned by opts.get_bufnrs() and will submit a PR if that works.

@patrickeibl patrickeibl linked a pull request Jul 27, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close buffers not included in opts.get_bufnrs() patrickeibl/cmp-buffer
1 participant
@patrickeibl