Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eat 0.9 terminal supports Sixel #197

Closed
sfllaw opened this issue Apr 16, 2024 · 3 comments · Fixed by #198
Closed

Eat 0.9 terminal supports Sixel #197

sfllaw opened this issue Apr 16, 2024 · 3 comments · Fixed by #198

Comments

@sfllaw
Copy link
Contributor

sfllaw commented Apr 16, 2024

The Eat terminal supports sixels: https://www.reddit.com/r/emacs/comments/172vgex/eat_09_released/

It looks like the proper way to detect it is to look for the EAT_SHELL_INTEGRATION_DIR environment variable: https://codeberg.org/akib/emacs-eat/src/commit/3a6f418f55d183b9d86f99c140caed4ba3d44f93/eat.el#L6993-L6994

The other alternative is to look for TERM that starts with eat-: https://codeberg.org/akib/emacs-eat/src/commit/3a6f418f55d183b9d86f99c140caed4ba3d44f93/eat.el#L4800-L4812

If you like, I can prepare a patch. It looks like it would go into detect_capabilities?

chafa/chafa/chafa-term-db.c

Lines 489 to 492 in d3bc4e7

if (!g_ascii_strcasecmp (term_name, "contour"))
{
gfx_seqs = sixel_seqs;
}

@hpjansson
Copy link
Owner

Yes, I'd be happy to take a PR! It's sufficient to check TERM (the same way as foot-), but if you also check EAT_SHELL_INTEGRATION_DIR, it may work better inside tmux/screen too.

@sfllaw
Copy link
Contributor Author

sfllaw commented Apr 18, 2024

@hpjansson I have implemented this in #198, which is ready for review.

hpjansson pushed a commit that referenced this issue Apr 19, 2024
The Eat terminal supports Sixel mode as of version 0.9:
https://www.reddit.com/r/emacs/comments/172vgex/eat_09_released/

The proper way to detect Eat is to look for the
EAT_SHELL_INTEGRATION_DIR environment variable. It also sets TERM with
the "eat-" prefix, i.e. "eat-truecolor".

Closes #197.
@hpjansson
Copy link
Owner

Eat looks interesting, I'll have to try it out. With a good terminal inside Emacs, my world would be complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants