Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logsumexp-plus ? #25

Open
srush opened this issue Dec 2, 2021 · 3 comments
Open

logsumexp-plus ? #25

srush opened this issue Dec 2, 2021 · 3 comments

Comments

@srush
Copy link

srush commented Dec 2, 2021

Is it possible to add logsumexp-plus (or am I missing it) ? Would be really useful, but seems a bit more complex than the other to do.

@thakkarV
Copy link
Contributor

@srush Hi! Thanks a lot! Surely is doable, and you may even be able to just use cuASR out of the box with it. But I can add it in with cuASR 1.2 release that will support Ampere. BTW, have you used cuASR? If so, may I ask what you are using it for?

@srush
Copy link
Author

srush commented Dec 27, 2021

Hi @thakkarV,

I haven't used it yet, but I am planning on using it as the backend of https://github.com/harvardnlp/pytorch-struct . Which currently has memory inefficient semiring implementations. CuASR max/+ will let us efficiently run Viterbi algorithms on very large models (like HMMs). If it had log-space (forward and backward) we could also train with it.

However wrapping the library for use in pytorch is proving harder than I thought. Need to figure that out first.

@thakkarV
Copy link
Contributor

thakkarV commented Dec 27, 2021

Ah I have forever wanted to use cuASR to run Viterbi. The original reason to support pluggable operators was so that we could do something like that (instead of just shortest path problems, which was our original goal). Can you please email me at thakkarv@gatech.edu ? I can share with you some more details on the timeline I have planned for features (Ampere uArch support and some changes I have planned to the operator struct API) and perhaps give you a hand with integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants