Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly require language flag for non-english mnemonics #275

Closed
wants to merge 2 commits into from
Closed

Explicitly require language flag for non-english mnemonics #275

wants to merge 2 commits into from

Conversation

lightclient
Copy link

Fixes #274.

Before:

$ wagyu ethereum import-hd --mnemonic "candy maple cake sugar pudding cream honey rich smooth crumble sweet treatt"
Error: MnemonicError(WordlistError(InvalidWord("candy")))

$ wagyu ethereum import-hd --mnemonic "candy maple cake sugar pudding cream honey rich smooth crumble sweet treat"
... success

After:

$ wagyu ethereum import-hd --language "english" --mnemonic "candy maple cake sugar pudding cream honey rich smooth crumble sweet treatt"
Error: MnemonicError(WordlistError(InvalidWord("treatt")))

$ wagyu ethereum import-hd --language "english" --mnemonic "candy maple cake sugar pudding cream honey rich smooth crumble sweet treat"
... success

Note how much easier it is to track down the error when the correct error for the language is returned!

@lightclient
Copy link
Author

@howardwu bumping.

@lightclient
Copy link
Author

@howardwu bump.

@lightclient lightclient closed this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ethereum import-hd fails with valid mnemonic
1 participant
@lightclient