Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image currently broken (ghcr.io/hound-search/hound:latest) #462

Open
moson-mo opened this issue May 7, 2023 · 7 comments · May be fixed by #463
Open

Docker image currently broken (ghcr.io/hound-search/hound:latest) #462

moson-mo opened this issue May 7, 2023 · 7 comments · May be fixed by #463

Comments

@moson-mo
Copy link
Contributor

moson-mo commented May 7, 2023

Hi,

The image is currently not working:

2023/05/07 09:24:26 Searcher started for Hound
2023/05/07 09:24:27 All indexes built!
2023/05/07 09:24:27 running server at http://localhost:6080
panic: open .build/ui/index.tpl.html: file does not exist

goroutine 1 [running]:
main.main()
	/go/src/github.com/hound-search/hound/cmds/houndd/main.go:187 +0x445

I guess it got published with the CI run of #459

Pushing a new docker image should probably not happen with pull requests, but only for new releases?

@oscrx oscrx linked a pull request May 10, 2023 that will close this issue
11 tasks
@oscrx
Copy link

oscrx commented May 11, 2023

Hey @moson-mo

I suggested a permanent fix to this issue in PR #463

You can use these images in the meantime, there are no changes apart from the improved pipeline steps
https://github.com/oscrx/hound/pkgs/container/hound

@dschott68
Copy link
Contributor

resolved by #460 and thank a million!

@oscrx
Copy link

oscrx commented Jun 8, 2023

Is #460 related?

Closing #463 does not help I guess...

@moson-mo
Copy link
Contributor Author

moson-mo commented Jun 8, 2023

I agree with @oscrx
The issue that the image is built is still there. Imho PR #463 should be re-opened and rebased.
My PR #460 only addressed the go::embed change, but not that "image publish on pull request" problem.

@oscrx
Copy link

oscrx commented Jun 8, 2023

I'll rebase it when I'm home. But I'm not sure I can reopen the PR by myself

@dschott68
Copy link
Contributor

apologies if premature closed. I did test the docker image and did not see this error. I'll reopen now and please let me know when you've retested yourself and what the results were. Cheers.

@dschott68 dschott68 reopened this Jun 8, 2023
@oscrx
Copy link

oscrx commented Jun 8, 2023

No problem, when the improved Github action is merged a new build can be triggered by tagging/releasing a new version. That should fix the latest image that is broken at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants