Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not support hot-reloading config.json ? #287

Open
StayTherapy opened this issue Jul 3, 2018 · 3 comments · May be fixed by #357
Open

Do not support hot-reloading config.json ? #287

StayTherapy opened this issue Jul 3, 2018 · 3 comments · May be fixed by #357
Labels
enhancement

Comments

@StayTherapy
Copy link

StayTherapy commented Jul 3, 2018 •
edited

If config.json was updated while the program was running , Hound do not reload the configure unless restart it . Are there ant plans to support hot-reloding ?
@salemhilal
Copy link
Contributor

That's not a bad idea. We'd definitely accept a pull request for something that solves this.

@elliotpeele elliotpeele linked a pull request Oct 16, 2020 that will close this issue
Open
@kkom
Copy link

kkom commented Feb 13, 2021 •
edited

Hey! I commented on the attached PR. @elliotpeele -- if you still want to finish this, I can do some testing on our deployment -- but it would be great if you could rebase the PR on top of master, as I don't want to lose any other work that was done in the meantime :)

@jiawen
Copy link

jiawen commented Jan 12, 2022

New Hound user here experimenting. Maybe we should add to README.md that Hound does not yet support hot reloading (and optionally point to #357).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reload config on update elliotpeele/hound
4 participants
@jiawen @salemhilal @kkom @StayTherapy