Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url-pattern: {url} - url:port is converted to url/port #193

Open
meeech opened this issue Feb 23, 2016 · 3 comments · May be fixed by #259
Open

url-pattern: {url} - url:port is converted to url/port #193

meeech opened this issue Feb 23, 2016 · 3 comments · May be fixed by #259
Labels
bug help wanted

Comments

@meeech
Copy link

meeech commented Feb 23, 2016

When git url contains a port
eg: ssh://git@stash.example.com:7999/foo/bar.git

the url is converted to http://stash.example.com/7999
@kylej-ibm
Copy link

Has anyone gotten around this issue?

@Roguelazer
Copy link

This is also problematic for me.

Roguelazer added a commit to EasyPost/hound that referenced this issue Sep 19, 2017
@Roguelazer
improve parsing of fully-protocoled URLs (fixes hound-search#193)
c2d8f11
@Roguelazer Roguelazer linked a pull request Sep 19, 2017 that will close this issue
Open
@afm-sayem
Copy link

Any update on this? Links to the original file is broken at the moment. If this gets merged can the port be a variable in url-patterns. In my use case, I need to be able to omit the port when the url is constructed.

@alexanderchiu alexanderchiu mentioned this issue Feb 20, 2021
Merged
Roguelazer added a commit to EasyPost/hound that referenced this issue Sep 27, 2021
@Roguelazer
improve parsing of fully-protocoled URLs (fixes hound-search#193)
6f36892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve parsing of fully-protocoled URLs EasyPost/hound
5 participants
@meeech @dschott68 @Roguelazer @afm-sayem @kylej-ibm