Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get CI to sign and notarize generated macOS builds #14

Open
athul opened this issue Mar 31, 2020 · 5 comments
Open

Get CI to sign and notarize generated macOS builds #14

athul opened this issue Mar 31, 2020 · 5 comments
Assignees
Projects

Comments

@athul
Copy link

athul commented Mar 31, 2020

It would be great if we could package the server for Mac(primary), Linux and Windows(In the near future). Goreleaser could be used with Travis CI or GH Actions.

I'll be happy to send a PR,

@NBTX
Copy link
Contributor

NBTX commented Jun 7, 2020

Goreleaser looks perfect - I'll look at getting that setup with GH actions or Travis CI now!
Thanks!

@NBTX
Copy link
Contributor

NBTX commented Jun 10, 2020

image
Success! We don't sign/notarize the builds automatically yet but that's in the pipeline, so I'll update this issue and add it to the roadmap.

@NBTX NBTX changed the title Packaging the Proxy for Mac Get CI to sign and notarize generated macOS builds Jun 10, 2020
@NBTX NBTX self-assigned this Jun 10, 2020
@NBTX NBTX added this to To do in Release 1.0 Jun 10, 2020
@NBTX NBTX pinned this issue Jun 10, 2020
@athul
Copy link
Author

athul commented Jun 10, 2020

Don't you think it's better to package as a tar.gz for mac(goreleaser doesn't support dmg I guess) since downloaded binaries are need a bit more work to run as an executable. We could also use fpm or nfpm for packaging it for linux machines

@NBTX
Copy link
Contributor

NBTX commented Jun 11, 2020

@athul I couldn't get goreleaser to work because we depend on CGO which isn't supported by goreleaser and cross-compiling failed every way I tried.

I figure a .zip compressed .app for macOS is sufficient and it'll work fine with stapling the notarization confirmation as long as I stable the binary and re-compress it.
As for the server build for macOS, I just exported the binary directly because it's easier to work with than a packaged .app and I believe the package to be unnecessary for server deployment.

For Linux, I was thinking of distributing via snapcraft.io.

@NBTX
Copy link
Contributor

NBTX commented Jun 11, 2020

I was initially going to develop and release per-platform installers that I would bundle the executable in but I ultimately decided that it would be too hard to maintain and opted instead to distribute the release binaries in some packaged form and simply have the binary install itself or guide the user through the process.

@NBTX NBTX assigned SamJakob and unassigned NBTX Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 1.0
  
To do
Development

No branches or pull requests

3 participants